Skip to content

chore: silence annoying compile warnings#3630

Closed
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev:chore.silence.annoying.compile.warnings
Closed

chore: silence annoying compile warnings#3630
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev:chore.silence.annoying.compile.warnings

Conversation

@rickeylev
Copy link
Copy Markdown
Collaborator

Protobuf was causing spammy C++ compile warnings. To fix them, silence them in copts.

@rickeylev rickeylev requested a review from aignas as a code owner February 23, 2026 07:40
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses excessive build log noise by introducing specific compiler flags to suppress -Wno-sign-compare warnings. This change aims to improve the clarity of build output, particularly when compiling external dependencies such as Protobuf, without altering the core logic of the codebase.

Highlights

  • Build Configuration: Added compiler options to .bazelrc to suppress -Wno-sign-compare warnings.
  • Warning Suppression: Specifically targeted "sign-compare" warnings originating from external dependencies like Protobuf to reduce build log noise.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .bazelrc
    • Added compiler options to suppress -Wno-sign-compare warnings for both host and target builds.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to silence C++ compiler warnings (-Wsign-compare) originating from external dependencies like Protobuf. The current implementation disables this warning globally, which could unintentionally hide similar issues in the project's own code. I've suggested a more targeted approach to apply the warning suppression only to the specific external repositories causing the noise, improving safety and maintainability.

@rickeylev
Copy link
Copy Markdown
Collaborator Author

Ugh. I forgot windows uses a different flag style. And there isn't a way to vary the flags with the global copt flag. Closing.

@rickeylev rickeylev closed this Feb 23, 2026
@rickeylev rickeylev deleted the chore.silence.annoying.compile.warnings branch February 23, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant