Skip to content

chore: print zipapp deprecation for non-windows platforms #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Feb 13, 2026
Merged

chore: print zipapp deprecation for non-windows platforms #3591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions python/private/py_executable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,10 @@ def _create_executable(
# When --build_python_zip is enabled, then the zip file becomes
# one of the default outputs.
if build_zip_enabled:
# buildifier: disable=print
print(
"""
if not is_windows:
# buildifier: disable=print
print(
"""
======================================================================
WARNING: Target: {}
The `--build_python_zip` flag and implicit zipapp output of `py_binary`
Expand All @@ -392,7 +393,7 @@ WARNING: Target: {}
https://github.com/bazel-contrib/rules_python/issues/3567
======================================================================
""".rstrip().format(ctx.label),
)
)

extra_default_outputs.append(zip_file)

Expand Down