Skip to content

docs: Fix broken links to bzlmod build_file_generation example#3464

Merged
aignas merged 1 commit intobazel-contrib:mainfrom
willstranton:fix_bzlmod_links
Dec 15, 2025
Merged

docs: Fix broken links to bzlmod build_file_generation example#3464
aignas merged 1 commit intobazel-contrib:mainfrom
willstranton:fix_bzlmod_links

Conversation

@willstranton
Copy link
Copy Markdown
Contributor

The examples/bzlmod_build_file_generation directory was moved under the gazelle directory in f92ad71

This fixes some outdated links/references to that old directory

The examples/bzlmod_build_file_generation directory was moved under the
gazelle directory in f92ad71

This fixes some outdated links/references to that old directory
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @willstranton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with broken links and outdated references in the project's documentation and configuration files. It ensures that all mentions of the bzlmod_build_file_generation example correctly reflect its new location under the gazelle directory, thereby improving the accuracy and navigability of the project's resources.

Highlights

  • Documentation Links: Updated several documentation links and references to correctly point to the bzlmod_build_file_generation example, which was recently moved to gazelle/examples/bzlmod_build_file_generation.
  • Configuration Cleanup: Removed an outdated entry from the .bazelignore file that referenced the old path of the bzlmod_build_file_generation example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates several broken links and references that pointed to the old location of the bzlmod_build_file_generation example. The changes in the documentation and configuration files look good. I've found one potential omission in the .bazelignore file where the new path for the moved example's build artifacts should probably be added to keep the repository clean from generated files. Other than that, this is a good fix.

examples/bzlmod/other_module/bazel-out
examples/bzlmod/other_module/bazel-testlogs
examples/bzlmod/py_proto_library/foo_external
examples/bzlmod_build_file_generation/bazel-bzlmod_build_file_generation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

You've removed the ignore entry for the old path, but it seems the entry for the new path is missing. To prevent Bazel-generated files from being accidentally committed, you should probably add an entry for the new location of the example's build artifacts: gazelle/examples/bzlmod_build_file_generation/bazel-bzlmod_build_file_generation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...it seems the entry for the new path is missing...

See line 29.

@aignas aignas added this pull request to the merge queue Dec 15, 2025
Merged via the queue into bazel-contrib:main with commit fe9fd2d Dec 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants