docs: Fix broken links to bzlmod build_file_generation example#3464
docs: Fix broken links to bzlmod build_file_generation example#3464aignas merged 1 commit intobazel-contrib:mainfrom
Conversation
The examples/bzlmod_build_file_generation directory was moved under the gazelle directory in f92ad71 This fixes some outdated links/references to that old directory
Summary of ChangesHello @willstranton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with broken links and outdated references in the project's documentation and configuration files. It ensures that all mentions of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates several broken links and references that pointed to the old location of the bzlmod_build_file_generation example. The changes in the documentation and configuration files look good. I've found one potential omission in the .bazelignore file where the new path for the moved example's build artifacts should probably be added to keep the repository clean from generated files. Other than that, this is a good fix.
| examples/bzlmod/other_module/bazel-out | ||
| examples/bzlmod/other_module/bazel-testlogs | ||
| examples/bzlmod/py_proto_library/foo_external | ||
| examples/bzlmod_build_file_generation/bazel-bzlmod_build_file_generation |
There was a problem hiding this comment.
You've removed the ignore entry for the old path, but it seems the entry for the new path is missing. To prevent Bazel-generated files from being accidentally committed, you should probably add an entry for the new location of the example's build artifacts: gazelle/examples/bzlmod_build_file_generation/bazel-bzlmod_build_file_generation.
There was a problem hiding this comment.
...it seems the entry for the new path is missing...
See line 29.
The
examples/bzlmod_build_file_generationdirectory was moved under the gazelle directory in f92ad71This fixes some outdated links/references to that old directory