use transition to resolve correct tar in oci_load#762
Closed
contagnas wants to merge 1 commit intobazel-contrib:mainfrom
Closed
use transition to resolve correct tar in oci_load#762contagnas wants to merge 1 commit intobazel-contrib:mainfrom
contagnas wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Collaborator
|
I am not sure if this workaround is fixing problems, or introducing more, i am even considering reverting #590. See: #590 (comment) |
Collaborator
|
Closing in favor of #794 |
thesayyn
pushed a commit
that referenced
this pull request
Dec 3, 2025
Hi @thesayyn, @alexeagle. I'd like to help solve the cross-platform remote execution issue described in [#769](#769), which significantly affects us. I see this is connected to the fundamental Bazel limitation described in [bazelbuild/bazel#19645](bazelbuild/bazel#19645). I've noticed that a similar issue was addressed for crane and yq toolchains in [#590](#590), but the same transition-based solution for tar toolchain ([#762](#762)) got stuck because it doesn't work well in other cases. ## Proposal I'm suggesting to use target_toolchain which was [recently implemented](bazel-contrib/tar.bzl#65) instead of toolchain to determine it correctly. As a prerequisite we need to migrate to tar.bzl. ## Changes summary 1. tar.bzl was used instead of `aspect_bazel_lib/tar.bzl` 2. target toolchain was used instead of toolchainl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to and based on #590
We're building
oci_loadtargets with RBE on linux machines, and the tar in the load script fails to execute on macos hosts.