Skip to content

feat: add support for riscv64#119

Open
ffgan wants to merge 2 commits intobazel-contrib:mainfrom
ffgan:riscv64
Open

feat: add support for riscv64#119
ffgan wants to merge 2 commits intobazel-contrib:mainfrom
ffgan:riscv64

Conversation

@ffgan
Copy link
Copy Markdown

@ffgan ffgan commented Jan 10, 2026

hi there.

Recently, riscv64 has gained widespread adoption. I'm also attempting to add riscv64 support to rules_oci and other projects. One of the dependencies of rules_oci is rules_multitool here, so I hope to add riscv64 support to rules_multitool.

I performed builds and tests on my riscv64 machine, and the results show that everything went smoothly. After adding this commit, rules_oci can also support rv64 very well. Therefore, I believe we can easily add riscv64 support to rules_multitool.

So if there are any questions about the above content, please feel free to @ me directly. I'm happy to answer all questions.


Other Info
Co-authored by: nijincheng@iscas.ac.cn;

ffgan added 2 commits January 10, 2026 12:19
Co-authored by: nijincheng@iscas.ac.cn;

Signed-off-by: ffgan <sudoemt@gmail.com>
Co-authored by: nijincheng@iscas.ac.cn;

Signed-off-by: ffgan <sudoemt@gmail.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b281fd19b3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -1,3 +1,5 @@
load("@rules_shell//shell:sh_test.bzl", "sh_test")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore workspace example by defining @rules_shell

In the WORKSPACE-based example, @rules_shell is never declared (checked examples/workspace/WORKSPACE.bazel), so adding load("@rules_shell//shell:sh_test.bzl", "sh_test") will make bazel test //:integration_test fail with an unresolved repository error. The previous usage relied on the native sh_test without any external repo. Either add a rules_shell repository to the workspace example or drop this load and use the native rule again.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant