Skip to content

fix: don't add transitive hubs to direct deps #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeagle merged 1 commit into from
Jan 7, 2026
Merged

fix: don't add transitive hubs to direct deps #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions multitool/extension.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ def _extension(module_ctx):
else:
lockfiles[h.hub_name] = [h.lockfile]

if not module_ctx.is_dev_dependency(h):
root_module_direct_deps[h.hub_name] = 1
else:
root_module_direct_dev_deps[h.hub_name] = 1
if mod.is_root:
(root_module_direct_dev_deps if module_ctx.is_dev_dependency(h) else root_module_direct_deps)[h.hub_name] = 1

# ensure _DEFAULT_HUB_NAME is present in non-dev and dev deps
# when non-dev and dev deps are non-empty.
Expand Down