fix(2.x): quote path variables in write_source_file#1242
Open
jfjonsson wants to merge 2 commits intobazel-contrib:2.xfrom
Open
fix(2.x): quote path variables in write_source_file#1242jfjonsson wants to merge 2 commits intobazel-contrib:2.xfrom
jfjonsson wants to merge 2 commits intobazel-contrib:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #1239 to 2.x. Fix
write_source_filefailing with shell syntax errors when paths contain metacharacters like parentheses.Problem
The generated shell script assigned paths to variables without quoting:
in=$runfiles_dir/path/to/(folder)/file.txt out=path/to/(folder)/file.txtBash interprets
(as the start of a subshell, causing:This breaks builds using Next.js App Router route groups (e.g.,
app/(dashboard)/page.tsx) or any path with parentheses, spaces, or other shell metacharacters.Fix
Quote the variable assignments:
Changes
lib/private/write_source_file.bzl: Quote path variable assignments in both bash and batch scriptslib/tests/write_source_files/write_source_file_test.bzl: Quote paths in test script generator(route-group)/test.js)Test plan
special_chars_in_path_testpasseswrite_source_filestests pass