Add default exports file to generate script (#1)#133
Open
franverona wants to merge 1 commit intobayesimpact:mainfrom
Open
Add default exports file to generate script (#1)#133franverona wants to merge 1 commit intobayesimpact:mainfrom
franverona wants to merge 1 commit intobayesimpact:mainfrom
Conversation
|
This PR need's to be approved soon as possible, this change is very important for clean codes. |
Author
|
Any chance that this will be merged soon? |
|
Absolute wildcard here but I really wish we could get this merged in it would be so much better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Description
After many months using the package on several projects, I've found that having one line per import for each icon might be a little bit overwhelming regarding "import maintenance".
With this PR the package will generate an
index.tsfile with all icons exported as default. Thus, the following snippets are equivalent:This change is