Skip to content

Conversation

@g-maxime
Copy link
Collaborator

@g-maxime g-maxime commented Feb 11, 2025

Windows std::stringstream maximum size is INT_MAX

https://github.com/microsoft/STL/blob/main/stl/inc/sstream#L323

Fixes #841

Windows std::stringstream maximum size is INT_MAX

Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
@JeromeMartinez
Copy link
Contributor

Windows std::stringstream maximum size is INT_MAX

I have doubts that it is what the spec expects!
In any case, it is not bad to avoid std::stringstream when not a lot needed because it uses to be slow.
At long term, replacing other std::stringstream by fmtlib (and later the C++20 std::format version) could be nice, but not urgent.

@JeromeMartinez JeromeMartinez merged commit 0e570ab into bavc:main Feb 11, 2025
10 checks passed
@JeromeMartinez JeromeMartinez deleted the 2gb-limit branch February 11, 2025 21:57
@g-maxime g-maxime mentioned this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncated XML Export

2 participants