This repository was archived by the owner on Sep 17, 2019. It is now read-only.
Update dependency eslint-config-prettier to v6 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
======================================
Coverage 99.6% 99.6%
======================================
Files 16 16
Lines 256 256
======================================
Hits 255 255
Misses 1 1 |
renovate
bot
force-pushed
the
renovate/eslint-config-prettier-6.x
branch
from
8ebe060 to
6447421
Compare
renovate
bot
force-pushed
the
renovate/eslint-config-prettier-6.x
branch
from
6447421 to
3d94cb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.9.0->6.2.0Release Notes
prettier/eslint-config-prettier
v6.2.0Compare Source
rule][@typescript-eslint/quotes-special]). Thanks to Masafumi Koba
(@ybiquitous)!
v6.1.0Compare Source
Masafumi Koba (@ybiquitous)!
v6.0.0Compare Source
Changed: The CLI helper tool now considers [no-confusing-arrow] to conflict
if you use the default value of its
allowParensoption. The default waschanged to
truein ESLint 6, which conflicts with Prettier.If the CLI helper tool gives you errors about this after upgrading, the
solution is to change this:
{ "rules": { "no-confusing-arrow": ["error"] } }Into this:
{ "rules": { "no-confusing-arrow": ["error", { "allowParens": false }] } }The latter works in both ESLint 6 as well as in ESLint 5 and older.
Improved:
eslint --print-configusage instructions. The CLI tool helptext as well as the documentation has been updated to suggest commands that
work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of
eslint --print-config ., useeslint --print-config path/to/main.js.)v5.1.0Compare Source
v5.0.0Compare Source
Removed: [react/self-closing-comp]. This rule was added in v4.1.0 not
because it conflicted with Prettier but because it was unnecessary when
using Prettier. However, in v1.18.0 [Prettier stopped converting empty
elements to self-closing elements][prettier-self-closing]. So the rule is
not unnecessary anymore.
If you use Prettier v1.17.1 or older you should be able to upgrade
eslint-config-prettier to v5.0.0 without having to do anything else.
If you use Prettier v1.18.0 or newer, you might get lint errors about for
example changing
<div></div>into<div />. You have two options:eslint --fixif you prefer to enforce self-closing elements wherepossible. This should fix all the errors.
"react/self-closing-comp": "off"to your ESLint config if you useautofix from your editor and you face the same [issue as Prettier
did][prettier-self-closing].
Changed: Node.js 6 is no longer officially supported, but v5.0.0 should
still work with it.
v4.3.0Compare Source
[vue/block-spacing], [vue/brace-style] and [vue/comma-dangle].
[@typescript-eslint/func-call-spacing] and [@typescript-eslint/semi].
v4.2.0Compare Source
(@Hoishin) and Jen Gorfine (@jgorfine)!
v4.1.0Compare Source
v4.0.0Compare Source
replaced with support for its successor [@typescript-eslint/eslint-plugin].
Thanks to TANIGUCHI Masaya (@ta2gch) and everyone else who helped with this!
[special rules][arrow-special], since they might cause problems if using
[eslint-plugin-prettier] and
--fix. They are turned off by default, and theCLI helper tool will warn about them (but not error if you do enable them).
This won’t break your linting checks, but do note that these rules will be
disabled unless you explicitly enable them again, and that you might see new
warnings when running the CLI helper tool.
v3.6.0Compare Source
(@silvenon)!
v3.5.0Compare Source
requires eslint-plugin-vue@5, while many use eslint-plugin-vue@4. In other
words, it was an accidental breaking change. Also, after thinking about it
some more, it makes sense to have a Prettier-specific list of rules, rather
than using the
vue/no-layout-ruleslist, since there can be layout rulesthat don’t conflict with but rather complement Prettier.
v3.4.0Compare Source
vue/no-layout-rulesconfig behind the scenes, so it should automaticallystay up-to-date when new eslint-plugin-vue versions are released. Thanks to
Michał Sajnóg (@michalsnik)!
v3.3.0Compare Source
rule][vue/html-self-closing-special]). Thanks to Yamagishi Kazutoshi (@ykzts)!
v3.2.0Compare Source
Thanks to Grant Snodgrass (@meeber)!
v3.1.0Compare Source
backticks. This means that the CLI helper tool no longer can automatically
validate it, so you’ll need to refer the [quotes special rule
documentation][quotes-special]. Thanks to Nick Petruzzelli (@npetruzzelli)!
v3.0.1Compare Source
eslint --print-configusage instructions.v3.0.0Compare Source
v2.10.0Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.