Nour/email verification #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowtorola
reviewed
Dec 7, 2025
lowtorola
reviewed
Dec 7, 2025
| queryCache: new QueryCache({ | ||
| onError: (error) => { | ||
| if (error instanceof ResponseError) { | ||
| // TODO: add special handling for 403 email verification erros |
Contributor
There was a problem hiding this comment.
We also need to let our custom backend errors have their messages show in their toasts as well.. seems like a whole future pr for these two tasks
Member
Author
There was a problem hiding this comment.
yeah might be a another frontend pr to resolve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces email verification as a requirement for key user actions in the competition and team APIs. It adds a new
email_verifiedfield to theUsermodel, creates a model for managing email verification tokens, and updates permissions across multiple endpoints to enforce email verification. Test cases and admin interfaces are also updated to support and validate this new flow.Email Verification Enforcement
IsEmailVerifiedpermission to all relevant endpoints incompete/views.pyandteams/views.py, ensuring only users with verified emails can create submissions, join/leave teams, and access team information. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]User Model and Database Changes
email_verifiedBoolean field to theUsermodel via migration, defaulting toFalse.EmailVerificationTokenmodel and migration for managing email verification tokens, including admin registration for viewing tokens. [1] [2] [3]Test Suite Updates
email_verified=True, reflecting the new permission requirements and preventing test failures. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Dependency Update
django-sortedm2mfrom version 3.1.1 to 4.0.0 inenvironment.yml.These changes collectively enforce email verification for users performing sensitive actions, provide the necessary backend infrastructure for verification tokens, and ensure the test suite remains robust under the new requirements.