Skip to content

feat: tailwindcss perf #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moacode merged 6 commits into from
Nov 19, 2020
Merged

feat: tailwindcss perf #22

moacode merged 6 commits into from
Nov 19, 2020

Conversation

@moacode
Copy link

@moacode moacode commented Nov 17, 2020 •
edited
Loading

Description

This PR improves TailwindCSS dev build performance by splitting up the various imports as per this tutorial.

Please merge in (or use) this PR while testing this feature.

Fixes #21

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've tested locally and observed a much faster build time.

@moacode
Copy link
Author

moacode commented Nov 17, 2020

@mikedaviesweb it would be great if you could check that I've set up the app-{base|components|utilities}.css files correctly (especially the fonts.css import).

@moacode moacode mentioned this pull request Nov 17, 2020
Open
1 task
@moacode moacode self-assigned this Nov 17, 2020
@moacode moacode changed the title Feat/tailwindcss perf feat: tailwindcss perf Nov 17, 2020
@mikedaviesweb
Copy link

mikedaviesweb commented Nov 17, 2020

Hey @thejoshsmith, looks good, this is how I did it on Te Pou with a few extra files.

app-base.css
app-components.css
app-utilities.css
base.css
fonts.css
components/components-container.css

judereid
judereid approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@judereid judereid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

judereid
judereid reviewed Nov 17, 2020
View reviewed changes
@mikedaviesweb
Copy link

mikedaviesweb commented Nov 17, 2020

@thejoshsmith let's roll with the structure by default.

app-base.css
app-components.css
app-utilities.css
base/fonts.css
base/variables.css
components/
utilities/

rb1193
rb1193 approved these changes Nov 18, 2020
View reviewed changes
Copy link

@rb1193 rb1193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me chaps

Josh Smith added 2 commits November 19, 2020 15:49
@moacode moacode merged commit 6431364 into master Nov 19, 2020
@moacode moacode deleted the feat/tailwindcss-perf branch November 19, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikedaviesweb mikedaviesweb Awaiting requested review from mikedaviesweb

2 more reviewers

@judereid judereid judereid approved these changes

@rb1193 rb1193 rb1193 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@moacode moacode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate tailwind imports

5 participants

@moacode @mikedaviesweb @judereid @rb1193