Replace calls to "Don't Save" button to "Delete" as Mountain Lion uses the latter #4
Conversation
Mountain Lion introduced deeper iCloud integration to its iWork apps as well as core OS X apps such as TextEdit and Preview. We now get an additional sheet wherein we can save files directly into iCloud. Part of this change is that the "Don't Save" button was replaced with "Delete" instead. Since Osaka relies on the text "Don't Save" certain specs in Mountain Lion fail. Replacing them to "Delete" makes the test pass but I would think it would break the specs in Lion and earlier. We may need to introduce some sort of intelligence to determine which button text exists based on the OS. Signed-off-by: Ealden Esto E. Escanan <ealden@gmail.com>
|
Yeah, this can't work :) It would break it on other versions. That said, I have mountain lion and haven't gotten this test failure before, so I'm a bit puzzled about it... |
|
That's interesting. Do you have iCloud configured on your Mountain Lion perhaps? On Apr 15, 2013, at 9:41 AM, Bas Vodde notifications@github.com wrote:
|
|
Nope, I don't have iCloud configured. Do you? Bas On 15 Apr, 2013, at 11:37 AM, Ealden Escanan notifications@github.com wrote:
|
|
Yes. I'm not sure how it would look like if iCloud was not set, but this is what I see: The delete button I mentioned is this: |
|
Ok, then it would probably be better to change the code to check if the "Don't Save" button exists, and if it doesn't exist then hit the Delete button. That should work also on non iCloud. Wow, someone uses iCloud :P |
2 participants
Specs fail in Mountain Lion as the "Don't Save" button is now "Delete". I would think this was caused by deeper iCloud integration in apps such as TextEdit. Specs in question should now pass in Mountain Lion.
I would think that this fix is not complete, as this should break things in Lion and earlier. Unfortunately I do not have an environment to confirm. May need to add a more intelligent check to call the correct button based on the OS.