-
Notifications
You must be signed in to change notification settings - Fork 121
Enable Windows Arm64 support #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable Windows Arm64 support #460
Conversation
|
Neither numpy nor cffi are available for Windows arm64. Also, Python x64 on arm64 reports being arm64, so this change would break the x64 installation. |
|
Hey, just to clarify—when you say numpy and cffi aren’t available on Windows ARM64, do you mean they don’t have their own ARM64 distributions on PyPI? Also, I’m a bit confused about the Python x64 on ARM64 reporting as ARM64—could you elaborate on how that would break the x64 installation? I tested building the package on both ARM64 and x64, and it seemed to work fine. |
|
I have an ARM64 Windows machine, with python installed in both an ARM64 version, and an AMD64 version. Numpy wheels are only available for install in the AMD64 version. The ARM64 version tries to install numpy.tar.gz, which fails, of course. If you run python AMD64 on an ARM64 device, it will report that |
|
Oh I understand now, thanks for the clarification! Just a quick note—if you have Visual Studio with MSVC installed, the numpy package works on ARM64 too, it will build successfully in that setup. |
|
Good to know, thank you! I will hold off on publishing Windows/ARM64 soundfile until both cffi and numpy are available for the platform. However, I also don't know yet how it would even work, given the above platform.machine confusion. If you'd like to contribute or discuss a possible solution, I'd be happy to merge that. |
|
@bastibe & @alinpahontu2912 I guess, right now we have both cffi and numpy being released for Windows ARM, this PR can be considered for review now |
|
That's wonderful news! Is this pull request ready to merge? |
Added checks to make use of the available libsndfile.dll for windows on arm64.
Numpy and cffi can be pip installed on arm64, so this should be available too.
Needed for torchaudio support on WinArm64