Upgrade to PoolBoy 1.3 #639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our fork of Poolboy is woefully out of date, which makes building systems on top of riak_core difficult when the system in question wants to use a more up-to-date poolboy. This change is needed to incorporate the related Poolboy PR in basho/poolboy#5.
NOTE: Before merging this PR, we'll need to merge the above Poolboy PR and tag the resulting merge as 1.3 (or some such) so that we can appropriately update the rebar.config on riak_core. This PR will be updated with that change once the poolboy PR is merged, but you can use this PR to test riak_core locally in the mean time.
Changes to riak_core are simple: