Customizable key-value separator and quoting#89
Closed
glebm wants to merge 1 commit intobasecamp:masterfrom
Closed
Customizable key-value separator and quoting#89glebm wants to merge 1 commit intobasecamp:masterfrom
glebm wants to merge 1 commit intobasecamp:masterfrom
Conversation
|
Kindly pinging the marginalia authors, how is it going here? Is this PR one that we can examine? Thanks. |
|
@glebm , can you rebase and check if Travis is passing. |
|
@balachandr I think he mailed PR #90 to fix the Travis build and that PR passes. |
|
Kindly pinging @arthurnn @sharshenov to please take a look at this PR. |
Contributor
|
@odeke-em Unfortunately, I'm not a maintainer and I don't have rights to merge. |
This is to make it easier to parse these comments from logs.
|
@glebm Any update about that? |
Author
|
I won't be rebasing this, feel free to pick it up and do it |
|
Hi all - I've done a re-take of this PR from my fork here: #130 The tests are passing and I can confirm that the smoke tests are passing as well. Let me know if there's anything else I can do to get this reviewed :) |
3 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make it easier to parse these comments from logs.