Skip to content

analytics | beacon only on doc-hide #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OmerKat merged 1 commit into from
Jan 1, 2026
Merged

analytics | beacon only on doc-hide #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/modules/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ export const createAnalyticsModule = ({
};

// currently disabled, until fully tested //
const beaconRequest = async (events: AnalyticsApiRequestData[]) => {
const beaconPayload = JSON.stringify({ events });
const beaconRequest = (events: AnalyticsApiRequestData[]) => {
try {
const beaconPayload = JSON.stringify({ events });
const blob = new Blob([beaconPayload], { type: "application/json" });
return (
typeof navigator === "undefined" ||
Expand All @@ -98,13 +98,21 @@ export const createAnalyticsModule = ({
}
};

const flush = async (eventsData: TrackEventData[]) => {
const flush = async (
eventsData: TrackEventData[],
options: { isBeacon?: boolean } = {}
) => {
if (eventsData.length === 0) return;

const sessionContext_ = await getSessionContext(userAuthModule);
const events = eventsData.map(
transformEventDataToApiRequestData(sessionContext_)
);

try {
return batchRequestFallback(events);
if (!options.isBeacon || !beaconRequest(events)) {
await batchRequestFallback(events);
}
} catch {
// do nothing
}
Expand Down Expand Up @@ -139,10 +147,10 @@ export const createAnalyticsModule = ({

const onDocHidden = () => {
stopAnalyticsProcessor();
clearHeartBeatProcessor?.();
// flush entire queue on visibility change and hope for the best //
const eventsData = analyticsSharedState.requestsQueue.splice(0);
flush(eventsData);
clearHeartBeatProcessor?.();
flush(eventsData, { isBeacon: true });
};

const onVisibilityChange = () => {
Expand Down