Skip to content

loginViaUsernamePassword -> loginViaEmailPassword #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netanelgilad merged 9 commits into from
Aug 15, 2025
Merged

loginViaUsernamePassword -> loginViaEmailPassword #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39c0747
loginViaUsernamePassword -> loginViaEmailPassword
netanelgilad Aug 14, 2025
50596c3
Fix test references: update loginViaUsernamePassword to loginViaEmail…
claude[bot] Aug 14, 2025
f8c2066
Update claude.yml - opus
netanelgilad Aug 14, 2025
088c2a7
Update claude-code-review.yml - opus
netanelgilad Aug 14, 2025
2e1008d
better preview versions - real npm registry (#20)
netanelgilad Aug 14, 2025
aaff18b
claude won't review itself
netanelgilad Aug 14, 2025
64bdeca
service role support (#19)
netanelgilad Aug 14, 2025
425ba6a
chore: bump version to 0.4.0
actions-user Aug 14, 2025
1622c7f
Merge remote-tracking branch 'origin/main' into loginViaUsernamePassw…
netanelgilad Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export function createAuthModule(
* @param turnstileToken - Optional Turnstile captcha token
* @returns Login response with access_token and user
*/
async loginViaUsernamePassword(
async loginViaEmailPassword(
email: string,
password: string,
turnstileToken?: string
Expand Down
10 changes: 5 additions & 5 deletions tests/unit/auth.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ describe('Auth Module', () => {
});
});

describe('loginViaUsernamePassword()', () => {
describe('loginViaEmailPassword()', () => {
test('should login successfully with email and password', async () => {
const loginData = {
email: 'test@example.com',
Expand All @@ -421,7 +421,7 @@ describe('Auth Module', () => {
.reply(200, mockResponse);

// Call the API
const result = await base44.auth.loginViaUsernamePassword(
const result = await base44.auth.loginViaEmailPassword(
loginData.email,
loginData.password
);
Expand Down Expand Up @@ -462,7 +462,7 @@ describe('Auth Module', () => {
.reply(200, mockResponse);

// Call the API
const result = await base44.auth.loginViaUsernamePassword(
const result = await base44.auth.loginViaEmailPassword(
loginData.email,
loginData.password,
loginData.turnstile_token
Expand Down Expand Up @@ -495,7 +495,7 @@ describe('Auth Module', () => {

// Call the API and expect an error
await expect(
base44.auth.loginViaUsernamePassword(loginData.email, loginData.password)
base44.auth.loginViaEmailPassword(loginData.email, loginData.password)
).rejects.toThrow();

// Verify all mocks were called
Expand All @@ -514,7 +514,7 @@ describe('Auth Module', () => {

// Call the API and expect an error
await expect(
base44.auth.loginViaUsernamePassword(loginData.email, loginData.password)
base44.auth.loginViaEmailPassword(loginData.email, loginData.password)
).rejects.toThrow();

// Verify all mocks were called
Expand Down