Conversation
- Add bug report template with structured fields - Add feature request template for enhancement proposals - Add pull request template with checklist - Templates follow GitHub's YAML issue form format Co-authored-by: Kfir Stri <kfirstri@users.noreply.github.com>
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.3-pr.44.1f8566cPrefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.3-pr.44.1f8566c"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.3-pr.44.1f8566c"
}
}
Preview published to npm registry — try new features instantly! |
PR Review: GitHub Issue and PR TemplatesThanks for adding these contribution templates! This is a valuable addition that will help standardize issue and PR submissions. Here's my comprehensive review: ✅ StrengthsCode Quality
Best Practices Alignment
🔍 Issues & Recommendations1. Bug Report - CLI Version Detection (bug_report.yml:58)Issue: Users need to manually find and enter the CLI version. placeholder: |
- OS: [e.g. macOS 14.0, Ubuntu 22.04, Windows 11]
- Node.js version: [e.g. 20.19.0] (run: node --version)
- CLI version: [e.g. 1.0.0] (run: base44 --version or npx base44 --version)2. PR Template - Test Command Specificity (PULL_REQUEST_TEMPLATE.md:34)Current:
Recommendation: Expand the testing checklist: - [ ] All tests pass (`npm test`)
- [ ] Type checking passes (`npm run typecheck`)
- [ ] Linting passes (`npm run lint`)3. PR Template - Build Step MissingIssue: AGENTS.md line 261 mentions - [ ] Build succeeds (`npm run build`)4. Feature Request - More CLI Context (feature_request.yml:40-43)Enhancement: The placeholder shows placeholder: |
```bash
# Example: if adding a new 'deploy' command
base44 deploy --environment production
# Output: Deploying to production...🔒 Security Considerations✅ Good practices:
|
Closes #43
Adds structured GitHub templates for:
These templates help contributors provide complete information and maintain consistency across issues and PRs.
Generated with Claude Code