Skip to content

fix(button): add default noopener noreferrer to ButtonWithLink #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devinvaughan wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

fix(button): add default noopener noreferrer to ButtonWithLink #2845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e472d53
Update ButtonWithLink.tsx
devinvaughan Dec 8, 2025
acc5b74
Update ButtonWithLink.tsx
devinvaughan Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/web/src/components/Button/ButtonWithLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,16 @@ export function ButtonWithLink({

...buttonProps
}: ButtonWithLinkProps) {
// If the link opens in a new tab and no rel is specified,
// default to "noopener noreferrer" to prevent tab-nabbing.
const computedRel =
rel ?? (target === '_blank' ? 'noopener noreferrer' : undefined);

return (
<Link
href={href}
target={target}
rel={rel}
rel={computedRel}
className={`${linkClassNames}${disabled ? ' pointer-events-none' : ''}`}
{...linkProps}
>
Expand All @@ -52,3 +57,4 @@ export function ButtonWithLink({
</Link>
);
}