Abstract vessel performance into configs, generalise performance calculation#343
Draft
thomaszwagerman wants to merge 6 commits intomainfrom
Draft
Abstract vessel performance into configs, generalise performance calculation#343thomaszwagerman wants to merge 6 commits intomainfrom
thomaszwagerman wants to merge 6 commits intomainfrom
Conversation
Contributor
Author
|
Marking some specific vessel performance tests as XFAIL, see #344 |
…e bug in depth polynomial calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336, these are very much breaking changes. Should be released as 2.0.0.
Target will be
mainoncetz/ruff->v1.1.9are merged.Added
@register_modeldecorator.ice_froude: Froude number-based ice resistance with configurable k/b/n coefficientswind_drag: Angle-dependent wind drag with interpolation options (linear/cubic/spline)wave_kreitner: Kreitner wave resistance with beam/length/block coefficient parameterspolynomial_fuel: Speed and resistance-based fuel consumption with polynomial coefficientspolynomial_battery: Speed and depth-based battery consumption for underwater vehiclesconstant_consumption: Fixed-rate consumption for simple vehiclesdocs/config/vessel_gallery.md)docs/methods/resistance_models.md)docs/reference/model_parameters.md)Changed
vessel_typereplaced withvessel_class+ explicit model specifications.Removed
SDA.py,SDA_wind.py,example_ship.py(ships)slocum.py(gliders)boatymcboatface.py(AUVs)twin_otter.py,windracer.py(aircraft)abstract_ship.py,abstract_glider.py,abstract_alr.py,abstract_plane.py,abstract_uav.py(abstract classes)vessel_type(replaced byvessel_class)hull_type(slender/blunt distinction now encoded in k/b/n coefficients)beam,force_limit(now in resistance model params)