Splitting Mesh into EnvironmentMesh and VehicleMesh#120
Draft
thomaszwagerman wants to merge 56 commits intomainfrom
Draft
Splitting Mesh into EnvironmentMesh and VehicleMesh#120thomaszwagerman wants to merge 56 commits intomainfrom
thomaszwagerman wants to merge 56 commits intomainfrom
Conversation
Contributor
Author
|
All required changes made and previous tests adapted to work, however test coverage is down to 76%. Probably a bit of effort required in identifying where testing is now lacking with the introduction of a few new mechanics. |
Contributor
Author
|
Another round of SIIS integration improvements integrated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78, closes #79, closes #80, closes #83, closes #91, closes #119, closes #155, closes #157
Summary of changes:
MeshintoEnvironmentMeshandVehicleMesh.Meshhas become an abstract class inherited by both.Vehicle.EnvironmentMeshandVehicleMeshfiles. If aVehicleMeshis ingested, it will identify theVehicleand check if it exists in the database, if not it will create it.select_mesh()updated to handle different types of meshes. In first instance search for aVehicleMeshthat matches coordinates ANDVehicle. Should this not exists, then find an EnvironmentMesh within coordinates and create aVehicleMeshusing supplied vehicle.optimise_route()is now a function which calls PolarRoute's optimisation functionality, not a task. Addedadd_vehicle_to_environment_meshfunction. Task is replaced by a newcreate_and_calculate_routetask which uses these functions to calculate optimal route usingVehicleMesh, creating one if necessary.SDA,SlocumandBoatyMcBoatFace.create_and_calculate_routetasks.TO DO: