Skip to content

Adding typehints#108

Draft
thomaszwagerman wants to merge 17 commits intomainfrom
tz/type_hints
Draft

Adding typehints#108
thomaszwagerman wants to merge 17 commits intomainfrom
tz/type_hints

Conversation

@thomaszwagerman
Copy link
Contributor

@thomaszwagerman thomaszwagerman commented Dec 30, 2025

Adding typehints throughout MeshiPhi.

Making changes where required by mypy (can also be called with make type-check), ensuring ruff check and pytest also all pass.

Adding in types-jsonschema to the [dev] requirements to allow typechecking of config_validation module (heavily uses jsonschema). See typeshed. There are still a lot of libraries we are ignoring, but this makes sure we don't have to ignore the whole config_validation module.

(also a small github actions/ version bump)

@davidwyld
Copy link
Contributor

I'm a bit confused at github-pages-docs being the merge target here?

@thomaszwagerman
Copy link
Contributor Author

thomaszwagerman commented Jan 14, 2026

Also attempting to pass mypy --strict, see

@thomaszwagerman
Copy link
Contributor Author

note to self: review ignore abc's

@thomaszwagerman
Copy link
Contributor Author

quite a few xarrary-related ignores, review

@thomaszwagerman
Copy link
Contributor Author

thomaszwagerman commented Jan 21, 2026

Double check the min time handling in ERA5 loaders (e.g. era5_wave_direction_vector.py)

@thomaszwagerman
Copy link
Contributor Author

I'm a bit confused at github-pages-docs being the merge target here?

Will change to main once #105 is merged

Base automatically changed from github-pages-docs to main January 28, 2026 12:37
@thomaszwagerman
Copy link
Contributor Author

Double check the min time handling in ERA5 loaders (e.g. era5_wave_direction_vector.py)

Saving this for a branch working on dataloaders specifically

@thomaszwagerman thomaszwagerman marked this pull request as ready for review February 3, 2026 11:54
@thomaszwagerman thomaszwagerman marked this pull request as draft February 3, 2026 16:08
@thomaszwagerman
Copy link
Contributor Author

thomaszwagerman commented Feb 3, 2026

Converting back to draft.

Changing cellbox id's from str to int is changing the results. Things like iteration order behaviour through the neighbor graph dictionary or floating point precision could be the source?

What the "correct" approach is might need to be determined by Jonny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants