Conversation
|
I'm a bit confused at |
|
Also attempting to pass |
|
note to self: review ignore abc's |
|
quite a few |
|
Double check the min time handling in ERA5 loaders (e.g. |
Will change to |
Saving this for a branch working on dataloaders specifically |
|
Converting back to draft. Changing cellbox id's from str to int is changing the results. Things like iteration order behaviour through the neighbor graph dictionary or floating point precision could be the source? What the "correct" approach is might need to be determined by Jonny. |
Adding typehints throughout MeshiPhi.
Making changes where required by
mypy(can also be called withmake type-check), ensuringruff checkandpytestalso all pass.Adding in
types-jsonschemato the[dev]requirements to allow typechecking ofconfig_validationmodule (heavily usesjsonschema). See typeshed. There are still a lot of libraries we are ignoring, but this makes sure we don't have to ignore the wholeconfig_validationmodule.(also a small github
actions/version bump)