Skip to content

Conversation

@bartwell
Copy link
Owner

Summary

  • rename the Firebase messaging module and stub to Firebase Cloud Messaging, updating package, class, and build artifact names
  • update module description, Kick accessor, and project includes to use the new FirebaseCloudMessaging naming
  • adjust supporting actions, delegates, and UI components to match the new Firebase Cloud Messaging namespace

Testing

  • ./gradlew :firebase-cloud-messaging:compileDebugKotlinAndroid (fails: SDK location not found in container)

https://chatgpt.com/codex/tasks/task_e_68f015370cc883268782bfa72a94b6d3

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +125 to +132
override fun copyToken(context: PlatformContext) {
state.value.token?.let { token ->
context.copyToClipboard("FCM Token", token)
}
}

override fun copyFirebaseId(context: PlatformContext) {
state.value.firebaseId?.let { id ->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Add missing PlatformContext import in default component

The new DefaultFirebaseCloudMessagingComponent implements copyToken and copyFirebaseId with parameters of type PlatformContext, but this file never imports ru.bartwell.kick.core.data.PlatformContext. Kotlin only auto-imports symbols from the same package, so these functions compile to unresolved references and the module will not build. Import the correct type (or use a fully qualified name) so the component compiles.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants