Skip to content

Conversation

@bartwell
Copy link
Owner

Summary

  • extract shared constants and restructure CPU sampling logic on Android to lower return count and remove magic numbers
  • replace hard-coded factors in JVM and iOS performance readers with named constants
  • centralize overlay store delimiter declaration to satisfy class ordering rules

Testing

  • ./gradlew detektCheckAll --console=plain

https://chatgpt.com/codex/tasks/task_e_68f0d32f64b48326907123f71e1ada69

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@bartwell bartwell changed the title Fix detekt findings for performance overlay metrics Add providers support in overlay metrics Oct 21, 2025
@bartwell bartwell merged commit 29690c3 into develop Oct 21, 2025
2 checks passed
@bartwell bartwell deleted the codex/add-overlay-module-with-provider-support branch October 21, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants