Skip to content

Comments

Add deploy to fly on PR#4

Closed
tverum wants to merge 2 commits intomainfrom
feature/add-fly-deploy
Closed

Add deploy to fly on PR#4
tverum wants to merge 2 commits intomainfrom
feature/add-fly-deploy

Conversation

@tverum
Copy link
Collaborator

@tverum tverum commented Jan 6, 2025

Followed the guide of this link.
Basically, on a PR open|sync|close|reopen -> will publish a review app to fly.io.

Will be available at https://pr---.fly.dev

Currently unsure if it actually published on a commit to master

@tverum
Copy link
Collaborator Author

tverum commented Jan 6, 2025

Need to add the Fly token to the github secrets still.
@bart6114 could you do that.

Otherwise I can't debug further.

@bart6114
Copy link
Owner

bart6114 commented Jan 8, 2025

PR deploy works now. Now let's also do an actual deploy when on main.

image

Should we not make this a simple switch? If on main, then do a regular deploy; if on PR, then do a PR deploy.

I'd also tend to think we should either:

  1. Put this as another job in the CI workflow, or
  2. Let the CI workflow trigger this deployment workflow (which, in my opinion, feels a bit hacky in GitHub)

It feels weird to have something deployed without tests. What do you think?

@bart6114
Copy link
Owner

bart6114 commented Mar 2, 2025

closing in favour of a simple deploy via fly ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants