Resolve Chinese character encoding issues in the command line#270
Open
lnlion wants to merge 3 commits intobart6114:mainfrom
Open
Resolve Chinese character encoding issues in the command line#270lnlion wants to merge 3 commits intobart6114:mainfrom
lnlion wants to merge 3 commits intobart6114:mainfrom
Conversation
Owner
|
Thanks a lot for the contribution 🙏 That said, this approach solves the issue specifically for Chinese output on Windows, but it’s a bit too platform- and encoding-specific to land in the main codebase as-is. I’ve proposed a more generic solution in PR #273, which allows you to specify output encoding per job via YAML. Also added some minor verification tests and added it to the docs. Would be highly appreciated if you can give #273 a try with something like below (I don't have access to a Windows machine so it's a bit tedious to mimick). jobs:
legacy_chinese_job:
command: legacy-chinese.exe
encoding: gb18030 |
Owner
|
Ping @lnlion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.