Fix config.toml enter_accept comment for default value #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary defaults to false for back compat but the comment implies that it defaults to true. config.toml overrides the built-in default "false" by setting it to "true" to improve usability for new users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a very minor comment in the default
config.toml, which says that theenter_acceptconfig option "Defaults to true" when theatuinbinary actually defaults tofalseif the option is not present / commented out.That comment confused me (I commented out the seemingly unnecessary line) because most comments like that one—including throughout the rest of this file—use "default" to describe what the code does if the option is not present (i.e. if it's commented out in this file).
Happy to reword as needed (or, feel free). I'm sure it can be improved.
Checks