Skip to content

feat: [sc-660057] Update bundler and oauth dependency #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BARK-AFUNG-SCHWARZ wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: [sc-660057] Update bundler and oauth dependency #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
773c7f1
feat: Update bundler and oauth dependency [sc-660057]
BARK-AFUNG-SCHWARZ Mar 30, 2023
47e11c7
Show the message of the error
BARK-AFUNG-SCHWARZ Jun 29, 2023
6ae696e
feat: Check class of errors
BARK-AFUNG-SCHWARZ Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions barkbox_client.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ Gem::Specification.new do |spec|
spec.add_dependency "rails", ">= 4.2.5.2"

spec.add_development_dependency "sqlite3"
spec.add_development_dependency "bundler", "~> 1.11"
spec.add_development_dependency "bundler", "~> 2.4.10"
spec.add_development_dependency "rake", "~> 10.0"
spec.add_development_dependency "rspec", "~> 3.5"
spec.add_development_dependency "rspec-rails", "~> 3.5"
spec.add_development_dependency "factory_girl_rails"
spec.add_development_dependency "webmock"

spec.add_runtime_dependency "multi_json"
spec.add_runtime_dependency "oauth2", "~> 1.4.0"
spec.add_runtime_dependency "oauth2", "~> 2.0"
end
14 changes: 11 additions & 3 deletions lib/barkbox_client/api_error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,21 @@ def initialize(response)
@errors = JSON.parse(response.body, symbolize_names: true)[:errors]
@errors = {general: errors} if errors.is_a?(String)
rescue => e
@errors = {general: 'Error'}
@errors = {general: e.message}
end
end

def pretty_errors
return @errors if @errors.is_a?(String)
@errors.map { |k, v| "#{k} #{v}" }.join(", ")
case @errors
when String
@errors
when Hash
@errors.map { |k, v| "#{k} #{v}" }.join(", ")
when NilClass
"@errors was nil"
else
"Unknown error format: #{@errors}"
end
end

def message
Expand Down