Skip to content

apply ShellCheck suggestions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baodrate merged 8 commits into from
Feb 13, 2022
Merged

apply ShellCheck suggestions #1

baodrate merged 8 commits into from
Feb 13, 2022

Conversation

@baodrate
Copy link
Owner

@baodrate baodrate commented Feb 13, 2022

Flupp and others added 8 commits March 7, 2021 14:43
@Flupp
fix SC2004: $/${} is unnecessary on arithmetic variables.
79531a7 
This is a suggestion from ShellCheck.
@Flupp
fix SC2046: Quote this to prevent word splitting.
4bd0b47 
This is a suggestion from ShellCheck.
@Flupp
fix SC2059: Don't use variables in the printf format string.
5d46334 
This is a suggestion from ShellCheck.
@Flupp
fix SC2071: > is for string comparisons. Use -gt instead.
418ef6c 
This is a suggestion from ShellCheck.
@Flupp
fix SC2086: Double quote to prevent globbing and word splitting.
76480c1 
This is a suggestion from ShellCheck.
@Flupp
fix SC2140: Word is of the form "A"B"C".
915634a 
This is a suggestion from ShellCheck.
@Flupp
fix SC2181: Check exit code directly
cb1041c 
… with e.g. 'if mycmd;', not indirectly with $?.

This is a suggestion from ShellCheck.
@baodrate
fix SC1090: directive to read snapper configs
503d464
@baodrate baodrate merged commit a42f661 into main Feb 13, 2022
@baodrate baodrate deleted the fix/shellcheck branch February 13, 2022 22:54
baodrate added a commit that referenced this pull request Feb 15, 2022
@baodrate
fix deltion of multiple failed backup snapshots
15ce90e 
fixes #6
regression introduced by shellcheck fixes (commit a42f661, PR #1).
multiple snapshots were passed to `snapper delete` as one argument.
revert this line and add shellcheck directive to silence error
@baodrate baodrate mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baodrate @Flupp