User show by yousukekaneko · Pull Request #22 · bambis13/airbnb

yousukekaneko · 2018-06-09T06:05:21Z

WHAT
user/show画面の実装

WHY
必須画面の為

これから、user-showの画面実装を行います。作業量重めのため、3日間工程で良いでしょうか？(月曜日夜完成予定)

# Conflicts: # Gemfile # app/assets/stylesheets/application.scss # app/assets/stylesheets/homes.scss

yousukekaneko · 2018-06-18T08:43:45Z

#WHAT
user_showの実装
#WHY
必須機能のため

bambis13 · 2018-06-18T12:22:27Z

レビューに出す時は[WIP]外しましょう〜！

yousukekaneko · 2018-06-18T13:36:09Z

すみません、[WIP]外しました。

以下、user/show画面になります。よろしくお願いします。

katsunori-takahashi · 2018-06-19T01:55:48Z

userのサムネイルって今の状態でuserに合わせて変わる状態ですか？
でもまぁ、view自体はできてるのでいいと思います！

yousukekaneko · 2018-06-20T06:34:00Z

関川くんのレビュー修正いたしました。
User.scss修正

高橋くん、左上のサムネイルはhostのimageになります。
hostの情報がないので、適当な画像を使っています。

yousukekaneko · 2018-06-20T06:35:03Z

ryosuke071111

html/cssは完璧だと思うのですが、rails関連の記述は直した方が良いと思う箇所がいくつかありました！

ryosuke071111 · 2018-06-20T06:47:14Z

app/views/users/show.html.haml

+  .user-show-left-contents-1
+    #user-show-left-contents-2
+      #user-media-container
+        %img#user-show-img{alt: "", src: "https://s3-ap-northeast-1.amazonaws.com/airbnb-images-to-s3/sample_user_image3.png"}/


%img#user-show-img{alt: "", src: "https://s3-ap-northeast-1.amazonaws.com/airbnb-images-to-s3/sample_user_image3.png"}/

ここって@userの変数展開は要らないんでしたっけ。。？

ryosuke071111 · 2018-06-20T06:57:09Z

app/views/users/show.html.haml

+
+    .listing-detail
+      リスティング
+      %small.small-number (6)


@user.homesみたいなやつ。。？

ryosuke071111 · 2018-06-20T06:57:53Z

app/views/users/show.html.haml

+      .panel-body
+      %dl.space-2.language-box
+        %dt.col-middle.dtbold 言語
+        %dd.col-middle.dtpadding English, Français


@user.languageみたいなやつ。。？

ryosuke071111 · 2018-06-20T06:59:18Z

app/views/users/show.html.haml

+      %li.listings-item
+        %a.listings-item-image{href: "/users"}
+          .text-relative
+            %img.img-responsive-height{alt: "appartamento con giardino e piscina", height: "144", src: "https://a0.muscache.com/im/pictures/17758895/9908f050_original.jpg?aki_policy=small", title: "appartamento con giardino e piscina", width: "225"}


@user.home.listing_photoみたいな。。？

ryosuke071111 · 2018-06-20T07:00:04Z

app/views/users/show.html.haml

+
+  .user-show-right-contents-1
+    .user-info-box
+      %h1.greeting-1 こんにちは、Mauroです！


@user.nameを入れられると思います。

ryosuke071111 · 2018-06-20T07:01:08Z

app/views/users/show.html.haml

+  .user-show-right-contents-1
+    .user-info-box
+      %h1.greeting-1 こんにちは、Mauroです！
+      .address-startday San Salvatore Monferrato, イタリア · 2013年1月からメンバー


@user.prefecture
@user.country_id.name

ryosuke071111 · 2018-06-20T07:02:57Z

app/views/users/show.html.haml

+      .self-information-2
+        .self-information-3{style: "margin-top:0;margin-bottom:24px;margin-right:25px"}
+          %img.image-attribute{alt: "", height: "50", src: "https://a0.muscache.com/airbnb/static/badges/super_host_50_new-e5e09829e1fc5ffefdb2d7387590c462.png", width: "28"}
+          %span._mstzcu.host-box-1 スーパーホスト


@user.superhostの有無で条件分岐できるかと！

ryosuke071111 · 2018-06-20T07:03:59Z

app/views/users/show.html.haml

+        = "(#{@users.count})"
+    .reviews_section.as_host ゲストからのレビュー
+
+    - @users.each do |user|


ここはuserにひもづくレビュー一覧なので
@reviews...な気がします。。！

ryosuke071111 · 2018-06-20T07:04:36Z

config/routes.rb

  get 'search', to: 'homes#search'
  resources :home_reservations, only: [:new, :create, :edit, :update]
+  # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
+  get 'users' => 'users#show'


これだとユーザーのID別でuser#showの出し分けができないと思います。。！

ryosuke071111 · 2018-06-20T07:05:17Z

app/controllers/users_controller.rb

+class UsersController < ApplicationController
+
+  def show
+    @users = User.all


userのidを取得できる記述を書いた方が良いかと思います。。！

bambis13 · 2018-06-18T12:16:47Z

app/controllers/users_controller.rb

+class UsersController < ApplicationController
+
+  def show
+    @users = User.all


ここはできればそのリスティングのuser_idを取得してその人のshowだけ表示するにしたいところ...!

bambis13 · 2018-06-18T12:18:35Z

app/views/users/show.html.haml

+      %i.fa.fa-flag-o このユーザーを報告
+      %p.self-imformation-1 Here we are, Pina and Mauro. Our adventure began thirty years ago with the house on the hill, the refuge of the family: two daughters, a grandmother with a passion for the vegetable garden and lots of animals! We offer a discreet hospitality, genuine lifestyle and enjoyment of uncontaminated nature. There you will meet us collecting fruits or eggs from our hens, while we dry herbs for infusions, or in the cellar to bottle the wine.
+      .self-information-2
+        .self-information-3{style: "margin-top:0;margin-bottom:24px;margin-right:25px"}


これはscssであてたい...!

対応しました。

bambis13 · 2018-06-18T12:19:32Z

app/views/users/show.html.haml

+        .self-information-3{style: "margin-top:0;margin-bottom:24px;margin-right:25px"}
+          %a._t8unl0{href: "/users/show/4655535#reviews", rel: "noopener noreferrer nofollow"}
+            ._1lhqvjz
+            #undefined_count._186vx4j


不要なclass,divは削除しましょう！

bambis13 · 2018-06-18T12:20:38Z

db/migrate/20180615065806_add_avatar_to_users.rb

@@ -0,0 +1,5 @@
+class AddAvatarToUsers < ActiveRecord::Migration[5.1]
+  def change
+    add_column :users, :avatar, :string


これstringで大丈夫ですか？

stringで問題なさそうです。
（AWSのS3から画像引っ張ってくるなら、255ビット超えないだろうと、、、）

bambis13 · 2018-06-18T12:21:07Z

config/routes.rb

  get 'search', to: 'homes#search'
  resources :home_reservations, only: [:new, :create, :edit, :update]
+  # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
+  get 'users' => 'users#show'


resources onlyにしましょう！

変更しました

yousukekaneko added 2 commits June 9, 2018 14:55

first commit

f1559f7

User-showの作成着手

061f8f3

これから、user-showの画面実装を行います。作業量重めのため、3日間工程で良いでしょうか？(月曜日夜完成予定)

bambis13 changed the title ~~User show~~ [WIP]User show Jun 12, 2018

yousukekaneko added 5 commits June 13, 2018 16:06

view_complete

c958d8e

Merge branch 'development' into user_show

957d514

# Conflicts: # Gemfile # app/assets/stylesheets/application.scss # app/assets/stylesheets/homes.scss

user_show_新機能実装前

3cbeab1

Merge branch 'development' into user_show

afdaf05

コンフリクトを解消(development=>user_show)

62fa466

yousukekaneko changed the title ~~[WIP]User show~~ User show Jun 19, 2018

yousukekaneko added 2 commits June 20, 2018 10:01

Users.scss修正

21786ac

サムネイルの変更

b3435d0

ryosuke071111 reviewed Jun 20, 2018

View reviewed changes

bambis13 reviewed Jun 20, 2018

View reviewed changes

Conversation

yousukekaneko commented Jun 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yousukekaneko commented Jun 18, 2018

Uh oh!

bambis13 commented Jun 18, 2018

Uh oh!

yousukekaneko commented Jun 18, 2018

Uh oh!

katsunori-takahashi commented Jun 19, 2018

Uh oh!

yousukekaneko commented Jun 20, 2018

Uh oh!

yousukekaneko commented Jun 20, 2018

Uh oh!

ryosuke071111 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yousukekaneko commented Jun 9, 2018 •

edited

Loading