feat: Add wrapped ICX token #463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
============================================
- Coverage 73.05% 73.02% -0.04%
- Complexity 1603 1620 +17
============================================
Files 116 118 +2
Lines 7686 7762 +76
Branches 936 951 +15
============================================
+ Hits 5615 5668 +53
- Misses 1667 1673 +6
- Partials 404 421 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AntonAndell
force-pushed
the
feat/wicx
branch
from
2809915 to
7fed623
Compare
TRSSMG
reviewed
Nov 20, 2024
| } | ||
|
|
||
| BigInteger getICXDeposit() { | ||
| return getICXDeposit(); |
Collaborator
There was a problem hiding this comment.
I think you want to return here Context.getValue();
TRSSMG
reviewed
Nov 20, 2024
|
|
||
| private String ensureNotEmpty(String str) { | ||
| Context.require(str != null && !str.trim().isEmpty(), "str is null or empty"); | ||
| assert str != null; |
Collaborator
There was a problem hiding this comment.
already thrown exception for str==null, assert not required I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: