add a Beacon client #184
add a Beacon client #184
Conversation
|
Changed branch to |
This replaces the hard-coded "2" and makes adding more "base" pages easier.
My service for sharing live GPS locations, see https://github.com/MaxKellermann/beacon A demo server is running on beacon.blarg.de; its IP address is currently 138.201.185.127, and this is the default value. There should be a way to use a DNS resolver, but that's a task for another day.
MaxKellermann
force-pushed
the
beacon
branch
from
84b378f to
4f076ea
Compare
|
Rebased. |
bailuk
left a comment
bailuk
left a comment
There was a problem hiding this comment.
I played around with this on AAT GTK connecting to your test Server.
Worked almost out of the box. Really impressive!
Also the code in your merge request looks generally fine to me.
I'd like to merge this as soon the library dependency issue is resolved.
I use jitpack for my own external libraries. See https://github.com/bailuk/foc for an example.
| } | ||
|
|
||
| sourceControl { | ||
| gitRepository(uri("https://github.com/MaxKellermann/beacon")) { |
There was a problem hiding this comment.
The GTK Variant gets released as flatpak. This means the build process must work Offline. (See https://github.com/bailuk/AAT/tree/stage/aat-gtk/flatpak).
This will break gradle inside flatpak builder.
| } | ||
|
|
||
| return formatAddress(address!!) | ||
| } |
There was a problem hiding this comment.
val address = getValue() ?: getDefaultValue()
return if (address == null) {
""
} else {
formatAddress(address)
}
| private fun createDispatcher() { | ||
| dispatcher.addSource(TrackerSource(serviceContext, appContext.broadcaster, UsageTrackerAlwaysEnabled())) | ||
| dispatcher.addSource(BeaconSource(serviceContext, appContext.broadcaster, UsageTrackerAlwaysEnabled())) | ||
| dispatcher.addSource(CurrentLocationSource(serviceContext, appContext.broadcaster)) |
There was a problem hiding this comment.
I managed to get this to work in the GTK Version by just adding
dispatcher.addSource(BeaconSource(appContext.services, appContext.broadcaster, UsageTrackerAlwaysEnabled()))to aat-gtk/src/main/kotlin/ch/bailu/aat_gtk/view/toplevel/MainWindow.kt
Which is really nice!
How does offline building work with dependencies from other Internet-based repositories like jitpack.io? |
2 participants
My service for sharing live GPS locations, see
https://github.com/MaxKellermann/beacon
A demo server is running on beacon.blarg.de; its IP address is currently 138.201.185.127, and this is the default value. There should be a way to use a DNS resolver, but that's a task for another day.
(I have posted this a long ago as PR #85 but didn't manage to finish it back then; I have now made a configuration page for it, and it's disabled by default. I hope we can get it ready for merging soon.)