feat: enable sourcemaps and ensure that files referenced in code fram…#528
Open
ryanthemanuel wants to merge 2 commits intobahmutov:mainfrom
Open
feat: enable sourcemaps and ensure that files referenced in code fram…#528ryanthemanuel wants to merge 2 commits intobahmutov:mainfrom
ryanthemanuel wants to merge 2 commits intobahmutov:mainfrom
Conversation
…es can be opened in user's IDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the plugin with default settings, code frames are not shown when failures occur:
This PR updates the default sourcemap setting to inline (though this can be overridden by the user), enabling code frames to appear in error output:
However, due to esbuild issue #2218, sourcemap paths are generated relative to the outfile location—which, by default, ends up in a system app data directory rather than the project root. As a result, file paths in code frames are confusing, and clicking them does not open the correct file in an editor.
To resolve this, we write to a temporary outfile located next to the source file, then move the compiled file to the directory that Cypress expects after the build completes. This makes code frames usable, with correct paths that open in an IDE as expected: