Draft
Conversation
…or#29233) Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com> Co-authored-by: Ariel Klikstein <ariel@elementor.com>
…lementor#29274) See https://github.com/orgs/elementor/discussions/21847 --------- Co-authored-by: Hein van Vlastuin <94352322+hein-obox@users.noreply.github.com>
… single size values [EDS-583] (elementor#29218) We'd like the border-radius and border-width support either their corresponding "corners" / "edges" prop types, but also a simple "size" prop type in case all dimensions are equal e.g. `border-radius` could be set with - ``` { $$type: 'corners', value: { 'top-left': { $$type: 'size', value: { size: 5, unit: 'px' }, }, 'top-right': { $$type: 'size', value: { size: 5, unit: 'px' }, }, 'bottom-right': { $$type: 'size', value: { size: 5, unit: 'px' }, }, 'bottom-left': { $$type: 'size', value: { size: 5, unit: 'px' }, }, } } ``` which will be translated to - ``` border-top-left-radius: 5px; border-top-right-radius: 5px; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; ``` but `border-radius` could instead just be - ``` { $$type: 'size', value: { size: 5, unit: 'px' }, } ``` and have a simpler CSS - ``` border-radius: 5px; ```
louiswol94
approved these changes
Nov 18, 2024
…#29305) Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #