feat: merge Send Feedback and Approve into single adaptive button#282
Closed
theflysurfer wants to merge 4 commits intobacknotprop:mainfrom
Closed
feat: merge Send Feedback and Approve into single adaptive button#282theflysurfer wants to merge 4 commits intobacknotprop:mainfrom
theflysurfer wants to merge 4 commits intobacknotprop:mainfrom
Conversation
…alias - resolve-file.ts: strip leading @ (coding agent file reference syntax) - pi-extension/index.ts: strip @ prefix + remove interactive file prompt - vite configs: add @plannotator/shared alias to fix build
Replace the two separate action buttons (Send Feedback + Approve) with a single button that adapts based on annotation count: - Has annotations → Send Feedback (accent color, chat icon on mobile) - No annotations → Approve (green/success, OK on mobile) This simplifies the UI by removing the need for users to choose between two actions. The approve warning dialog is no longer needed since Approve only appears when there are no annotations to lose. Removed: - showApproveWarning state - ConfirmDialog for approve-with-annotations warning - Separate Approve button with hover tooltip
Owner
|
Cool idea, I'll give it a run today. |
Owner
|
@theflysurfer whyd you close? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the two separate action buttons (Send Feedback + Approve) with a single button that adapts based on annotation count:
Motivation
Simplifies the review UI by removing the need for users to choose between two actions. The correct action is always obvious based on context.
Changes
<button>that switches behavior/style based ontotalAnnotationCountshowApproveWarningstate (no longer needed — Approve only shows when there are 0 annotations)ConfirmDialogwarning for approving with annotations