feat: add octave visual indicator on right column#36
Merged
Conversation
Display current octave on scene buttons (19-89) similar to how transpose is shown on the bottom row: - All 8 LEDs lit = default octave (5) - LEDs off from bottom = higher octave (6-10) - LEDs off from top = lower octave (0-4) Also adds octave reset: pressing both up+down together resets to default octave (5), matching the transpose reset behavior. Changes: - Add held state tracking for octave up/down buttons - Add reset_page_octave() function - Update render_controls() to include octave parameter - Update documentation (controls, button-layout, modules) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When scale lock is enabled, out-of-scale pads now block all MIDI output including aftertouch, not just note-on events. This prevents unexpected effects from being triggered by pressing blocked pads. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
reset_page_octave()functionrender_controls()to include octave parameter and render indicatorVisual Indicator
Test plan
🤖 Generated with Claude Code