Refactor Core Logic and Improve Code Maintainability

[b1sted]

This pull request introduces a series of significant refactorings and fixes aimed at improving the overall code quality, maintainability, and robustness of the application. The codebase has been evolved from using hardcoded "magic numbers" to a more structured, encapsulated, and type-safe design.

Key Changes:

• ✨ Centralized and Scoped Configuration:

  • Initially, all magic numbers and configuration parameters were centralized into a global constants.h file to eliminate hardcoded values from the source code.
  • This was further refined by moving module-specific constants from the global header into their respective .c files using static const. This improves encapsulation, reduces global namespace pollution, and provides better type safety than preprocessor macros.

• 📚 Robust User Input Handling:

  • The logic for parsing user responses ("да"/"нет") has been completely redesigned. Hardcoded strcmp checks have been replaced with a new, extensible response_dictionary module.
  • This approach makes the code cleaner, eliminates magic strings from the input logic, and allows for easy addition of new response keywords in the future without touching the input-handling code.

• 🐞 Bug Fixes and Styling:

  • A bug in user-facing comments and printf statements has been corrected to accurately describe the calculated parameter ("leading edge" instead of "trailing edge").
  • Code formatting has been standardized in key areas (e.g., switch statements) to improve readability.

Goal:

The primary goal of these changes is to transition the codebase from a functional prototype to a more stable and maintainable foundation. This makes future development easier and reduces the risk of introducing bugs.

[Copilot]

Pull Request Overview

This PR refactors the codebase to remove hardcoded “magic numbers” in favor of scoped constants, introduces a new response_dictionary module for cleaner input handling, and standardizes related function signatures and file paths.

• Moved global and module-specific magic numbers into constants.h and static const definitions.
• Added response_dictionary for extensible parsing of user inputs (“да”/“нет”).
• Updated function calls, error messages, and file operations to use the new constants and cleaned up styling.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/signal_analysis.c	Replaced #define N with ARRAY_SIZE and simplified forming calls.
src/response_dictionary.c	New module mapping input keywords to ResponseType.
src/parameter.c	Replaced local magic numbers with constants and refactored precision loop.
src/output.c	Replaced hardcoded banner path with FILE_PATH_ZAST.
src/input.c	Replaced manual strcmp checks with response_dictionary and buffer const.
src/forming.c	Moved magic numbers into static const parameters and updated logic.
src/file.c	Swapped literal file paths for FILE_PATH_* macros.
include/response_dictionary.h	Added header for the new response-mapping API.
include/forming.h	Updated prototypes for forming_Uvx and forming_Uvix.
include/constants.h	New header defining array size and file-path macros.

Comments suppressed due to low confidence (2)

src/response_dictionary.c:47

• Add unit tests for get_response_type_by_keyword to cover affirmative, negative, and unknown inputs, as well as edge cases.

ResponseType get_response_type_by_keyword(const char *input) {

src/parameter.c:66

• Consider adding unit tests for calculate_with_precision to verify the iterative precision logic, convergence behavior, and warning path when maximum array size is reached.

void calculate_with_precision() {

[Copilot]

prev_parameter is never updated to current_parameter, so current_precision is never recalculated and the loop cannot terminate. Add prev_parameter = current_parameter; after computing the precision.

[Copilot]

[nitpick] The break; after return true; is unreachable. You can remove this break (and the similar one after return false;) to simplify the code.

[Copilot]

[nitpick] Consider normalizing the input (e.g., converting to lowercase) and using a case-insensitive comparison (e.g., strcasecmp) instead of enumerating every casing variant in the dictionary.

Suggested change

	#include "response_dictionary.h"
	const KeywordMapping RESPONSE_DICTIONARY[] = {
	// Утвердительные ответы
	{"да", RESPONSE_AFFIRMATIVE},
	{"Да", RESPONSE_AFFIRMATIVE},
	{"дА", RESPONSE_AFFIRMATIVE},
	{"ДА", RESPONSE_AFFIRMATIVE},
	// Отрицательные ответы
	{"нет", RESPONSE_NEGATIVE},
	{"Нет", RESPONSE_NEGATIVE},
	{"нЕт", RESPONSE_NEGATIVE},
	{"неТ", RESPONSE_NEGATIVE},
	{"НЕт", RESPONSE_NEGATIVE},
	{"нЕТ", RESPONSE_NEGATIVE},
	{"НЕТ", RESPONSE_NEGATIVE}
	};
	const int DICTIONARY_SIZE = sizeof(RESPONSE_DICTIONARY) / sizeof(RESPONSE_DICTIONARY[0]);
	ResponseType get_response_type_by_keyword(const char *input) {
	for (int i = 0; i < DICTIONARY_SIZE; i++) {
	if (strcmp(input, RESPONSE_DICTIONARY[i].keyword_text) == 0) {
	return RESPONSE_DICTIONARY[i].type;
	}
	}
	return RESPONSE_UNKNOWN;
	}
	#include <ctype.h>
	#include "response_dictionary.h"
	const KeywordMapping RESPONSE_DICTIONARY[] = {
	// Утвердительные ответы
	{"да", RESPONSE_AFFIRMATIVE},
	// Отрицательные ответы
	{"нет", RESPONSE_NEGATIVE}
	};
	const int DICTIONARY_SIZE = sizeof(RESPONSE_DICTIONARY) / sizeof(RESPONSE_DICTIONARY[0]);
	ResponseType get_response_type_by_keyword(const char *input) {
	char normalized_input[256];
	normalize_to_lowercase(input, normalized_input);
	for (int i = 0; i < DICTIONARY_SIZE; i++) {
	if (strcmp(normalized_input, RESPONSE_DICTIONARY[i].keyword_text) == 0) {
	return RESPONSE_DICTIONARY[i].type;
	}
	}
	return RESPONSE_UNKNOWN;
	}
	void normalize_to_lowercase(const char *input, char *output) {
	for (int i = 0; input[i] != '\0'; i++) {
	output[i] = tolower((unsigned char)input[i]);
	}
	output[strlen(input)] = '\0';
	}