Skip to content

[TASK] Catch error while flushing cache tags #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochorocho merged 1 commit into from
Jun 2, 2025
Merged

[TASK] Catch error while flushing cache tags #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Build/phpunit/FunctionalTestsBootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/*
* This file is part of the TYPO3 CMS project.
*
Expand Down
1 change: 1 addition & 0 deletions Build/phpunit/UnitTestsBootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/*
* This file is part of the TYPO3 CMS project.
*
Expand Down
8 changes: 7 additions & 1 deletion Classes/Cache/Backend/ReverseProxyCacheBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/

use B13\Proxycachemanager\Provider\ProxyProviderInterface;
use Psr\Log\LoggerAwareTrait;
use TYPO3\CMS\Core\Cache\Backend\TransientBackendInterface;
use TYPO3\CMS\Core\Cache\Backend\Typo3DatabaseBackend;
use TYPO3\CMS\Core\Database\ConnectionPool;
Expand All @@ -30,6 +31,7 @@
*/
class ReverseProxyCacheBackend extends Typo3DatabaseBackend implements TransientBackendInterface
{
use LoggerAwareTrait;
protected ProxyProviderInterface $reverseProxyProvider;

public function setReverseProxyProvider(ProxyProviderInterface $reverseProxyProvider)
Expand Down Expand Up @@ -113,7 +115,11 @@ public function flushByTags(array $tags)
$this->reverseProxyProvider->flushCacheForUrls($urls);
}

parent::flushByTags($tags);
try {
parent::flushByTags($tags);
} catch (\Throwable $e) {
$this->logger->error('Failed to flush ' . count($tags) . ' tags. SQL query limit exceeded. See the list of all tags ' . implode(', ', $tags));
}
}

/**
Expand Down