Open
Conversation
Owner
|
Hey Ethan, please add tests and run |
b-fuze
reviewed
Jun 26, 2024
|
|
||
| // Merge adjacent text nodes | ||
| while (nextNode && nextNode.nodeType === NodeType.TEXT_NODE) { | ||
| if (currentNode.nodeValue) { |
Owner
There was a problem hiding this comment.
You don't need this if, adding an empty string would have the same effect
Owner
There was a problem hiding this comment.
Also, noticing that this if will drop the text from non-empty text nodes that follow empty text nodes
Owner
There was a problem hiding this comment.
Also, following the standard algorithm outlined here if any of the first text nodes found before others is empty then it's deleted and then the first non-empty text node will receive your currentNode treatment as you have here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality Added: Implemented the normalize function within the Node class.
Purpose: Merges adjacent text nodes and removes empty text nodes to clean up the DOM structure.
Methodology:
TypeScript Compliance: Ensured type safety by handling potential null values in nodeValue.