Adding roverlight and Symphony deprecation #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 22, 2025 13:03
- Added roverlight variant with optimized Docker builds - Removed Symphony integration and related scripts - Updated documentation for standard Terraform workspace structure - Added multi-platform support (AMD64/ARM64) - Enabled Docker layer caching for improved performance Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
- Added Dockerfile.roverlight for multi-platform builds - Added GitHub Actions workflows for builds and security - Added ROVERLIGHT.md documentation Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
There was a problem hiding this comment.
PR Overview
This pull request updates the development container configuration and GitHub workflows to support a new lightweight version of the rover container (Roverlight) while deprecating Symphony configurations. Key changes include:
- Addition of dedicated GitHub workflows for building, releasing, and security scanning Roverlight images.
- Updates to the devcontainer, Dockerfile, and documentation to clearly differentiate between the standard and light container variants.
- Enhancements in the dependabot configuration and cache upgrade for improved CI efficiency.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/roverlight-build.yml | New workflow for building and releasing Roverlight images with caching and scanning support. |
| .github/workflows/roverlight-security-scan.yml | New workflow for security scanning of Roverlight images. |
| docs/ROVERLIGHT.md | Documentation outlining the features and usage of the Roverlight container. |
| README.md | Updated badges and description to include references to both standard and light variants. |
| .github/dependabot.yml | Added devcontainers package ecosystem with daily update schedule. |
| docs/DEV_CONTAINER.md | Updated details to reflect the two available variants of the development container. |
| .github/workflows/rover.yml | Updated Docker layer caching to v3 for improved performance. |
| docs/USAGE.md | Revised usage documentation, removing outdated CI/CD references. |
| docs/CONTINOUS_INTEGRATION.md | Removed obsolete CI integration documentation. |
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
added 2 commits
February 22, 2025 13:51
…config Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
devin-ai-integration
bot
force-pushed
the
roverlight
branch
from
b7f8a73 to
dfaa762
Compare
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
…uilds Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
… scan Co-Authored-By: Arnaud Lheureux <arnaud.lheureux@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Roverlight, a streamlined version of the Rover container, and deprecates Symphony. Key changes include the addition of new GitHub workflows for building and scanning Roverlight images, updated documentation reflecting the new variants, and changes to Dependabot and devcontainer configurations.
Reviewed Changes
Copilot reviewed 22 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/roverlight-build.yml | New build and release workflow with multi-platform support and caching. |
| .github/workflows/roverlight-security-scan.yml | New security scan workflow; uses a hardcoded image tag. |
| docs/ROVERLIGHT.md | Documentation for the new Roverlight container. |
| .github/dependabot.yml | Added devcontainers ecosystem with a daily update schedule. |
| README.md | Updated badges and variant descriptions. |
| docs/DEV_CONTAINER.md | Updated to reference both Standard and Light container variants. |
| .github/workflows/rover.yml | Updated Docker layer caching configuration with a new actions version. |
| docs/USAGE.md | Removed CI/CD command references and updated the base directory option. |
| docs/CONTINOUS_INTEGRATION.md | Removed obsolete CI documentation. |
Files not reviewed (10)
- .devcontainer/Dockerfile: Language not supported
- .devcontainer/devcontainer.json: Language not supported
- .devcontainer/docker-compose.yml: Language not supported
- Dockerfile: Language not supported
- Dockerfile.roverlight: Language not supported
- docker-bake.hcl: Language not supported
- docker-bake.override.hcl: Language not supported
- scripts/build_image.sh: Language not supported
- scripts/cd.sh: Language not supported
- scripts/ci.sh: Language not supported
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the development container setup, workflow configurations, and Dockerfile improvements. The most important changes include replacing Docker Compose with a single Dockerfile, updating the devcontainer configuration, and adding new GitHub workflows for building and scanning containers.
Development Container Updates:
.devcontainer/Dockerfile: Removed the Dockerfile used for Docker Compose setup..devcontainer/devcontainer.json: Updated the configuration to use a new base image, added volume mounts, run arguments, and features for the development container.Workflow Configuration Changes:
.github/workflows/rover-preview.yml: Removed the workflow for building Rover preview images..github/workflows/rover.yml: Updated the workflow to use a new cache action version..github/workflows/roverlight-build.yml: Added a new workflow for building and releasing Roverlight images with caching and security scanning steps..github/workflows/roverlight-security-scan.yml: Added a new workflow for security scanning of Roverlight images.Dockerfile Improvements:
Dockerfile: Refactored the Dockerfile to streamline ARG and ENV declarations, updated package installations, and added new repositories and keys for dependencies. [1] [2]Dependabot Configuration:
.github/dependabot.yml: Added a new package-ecosystem for devcontainers with a daily update schedule.