Skip to content

Conversation

@bySabi
Copy link

@bySabi bySabi commented Jun 28, 2016

I update package dependencies to latest and all 7 test passed.

Is a warnnig on the command line:

npm WARN prova@2.1.2 license should be a valid SPDX license expression

that can be solved is you choose another, more specific, BSD license

@azer
Copy link
Owner

azer commented Jun 28, 2016

could you try it on browser, too ? node test -b

@bySabi
Copy link
Author

bySabi commented Jun 28, 2016

a something more is need cause node test -b not work even on master branch:

.... ~/Documents/Projects_git/WIP/prova on master [!]
$ node test -b
/Users/.../Documents/Projects_git/WIP/prova/lib/browser.js:35
var onSourceCodeChange = require("pubsub")();
                                          ^

TypeError: require(...) is not a function
    at Object.<anonymous> (/Users/.../Documents/Projects_git/WIP/prova/lib/browser.js:35:43)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/.../Documents/Projects_git/WIP/prova/index.js:26:3)
    at Module._compile (module.js:541:32)

@azer
Copy link
Owner

azer commented Jun 28, 2016

that should be fixed now

@bySabi
Copy link
Author

bySabi commented Jun 28, 2016

Yes! is fixed!
Test on upgrade branch passed on browsers too:

 Visit http://localhost:7559 to run the tests


  4 passed assertions.
  Browser: Chrome v51 Engine: WebKit v537.36 OS: Mac OS v10.11.5


  4 passed assertions.
  Browser: Firefox v47 Engine: Gecko v47.0 OS: Mac OS v10.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants