Open
Conversation
…error is not a string.
Author
|
Ping? This is a straightforward bugfix, so I'd like to get it into the official version of macropy3, if possible. :) |
Owner
|
It would be nice to have a testcase ;-) |
Author
|
Now that I noticed the conflicts alert, it seems you already fixed this - in exactly the same way as I did - in 9cac7df. ;) But I suppose I can provide a test before closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid crashing in error logger when the message of a macro expansion failure is not a string.
This happens more often than one would think, when developing new macros :)