Fix handling of multiple block macros in the same with statement#22
Fix handling of multiple block macros in the same with statement#22Technologicat wants to merge 2 commits intoazazel75:masterfrom
Conversation
… ordering), even if new_tree completely replaces in_tree.body
|
Can you please add a testcase for this? thanks |
|
Sure, I'll add a test for this too. Since I originally posted this PR, I've discovered that my fix still doesn't handle the fully general case correctly, but I haven't had time to investigate it further or to create a minimal example that reproduces the bug. What I've noticed is problems may occur with two-pass macros (that both |
…here the inner macro returns a completely new tree
|
Here's a test for the basic case for two block macros in the same I think the more complex cases could be handled at some later time? |
|
Ping? Need more complex test cases, or is this fine now? |
See issue #21 for details.