Skip to content

Comments

Option to scale images to same range across multiple models#71

Merged
aymgal merged 3 commits intoaymgal:mainfrom
aangress:normalization-feature
Oct 27, 2025
Merged

Option to scale images to same range across multiple models#71
aymgal merged 3 commits intoaymgal:mainfrom
aangress:normalization-feature

Conversation

@aangress
Copy link
Contributor

Currently, images are normalized according to their individual extrema. I'm attempting to implement a utility function that calculates a global vmin/vmax that you can use in MultiModelPlotters to normalize across all images using the global values. WiP

@aymgal
Copy link
Owner

aymgal commented Oct 14, 2025

Hi @aangress , thank you very much for your implementations! This looks really great. I will do my very best to review this by the end of this week (I'm quite busy these days, sorry!). Hope this is fine by you (but don't hesitate to open new pull requests in the meantime if you like).

@aymgal
Copy link
Owner

aymgal commented Oct 16, 2025

@aangress Looks mostly good, I just have a few comments:

  • It would be better to have explicit keyword arguments to the function, instead of **kwargs. It would make it easier for the user to use the function, and simplify the code as well. I am not sure to follow the need for del statements for instance, and perhaps having explicit kwargs would remove the need for this?
  • Could you write the docstring in the same format is in e.g. this code ("Numpydoc" style)

@aangress
Copy link
Contributor Author

@aymgal Just addressed your comments. I also added the function to notebook 04 for the model comparison as I figure this is a pretty good way to show the functionality. Let me know if it all makes sense!

@aangress
Copy link
Contributor Author

@aymgal Fixed conflicts!

@aymgal
Copy link
Owner

aymgal commented Oct 27, 2025

Thanks @aangress !

@aymgal aymgal merged commit a2d6cf4 into aymgal:main Oct 27, 2025
1 of 2 checks passed
@aangress aangress deleted the normalization-feature branch October 28, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants