Option to scale images to same range across multiple models#71
Merged
aymgal merged 3 commits intoaymgal:mainfrom Oct 27, 2025
Merged
Option to scale images to same range across multiple models#71aymgal merged 3 commits intoaymgal:mainfrom
aymgal merged 3 commits intoaymgal:mainfrom
Conversation
Owner
|
Hi @aangress , thank you very much for your implementations! This looks really great. I will do my very best to review this by the end of this week (I'm quite busy these days, sorry!). Hope this is fine by you (but don't hesitate to open new pull requests in the meantime if you like). |
Owner
|
@aangress Looks mostly good, I just have a few comments:
|
Contributor
Author
|
@aymgal Just addressed your comments. I also added the function to notebook 04 for the model comparison as I figure this is a pretty good way to show the functionality. Let me know if it all makes sense! |
Contributor
Author
|
@aymgal Fixed conflicts! |
Owner
|
Thanks @aangress ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, images are normalized according to their individual extrema. I'm attempting to implement a utility function that calculates a global vmin/vmax that you can use in MultiModelPlotters to normalize across all images using the global values. WiP