Potential Division by Zero in ETA Calculation #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aditya8369 is attempting to deploy a commit to the Ayan manna's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for creating a PR for your Issue!
|
Contributor
Author
|
@ayanmanna123 check |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
Owner
|
fix all error |
Contributor
Author
|
@ayanmanna123 done |
Owner
|
Due to some reason, you did not get any point of this pr if now i marge this pr, I will merge it after solving the issue |
Contributor
Author
|
@ayanmanna123 are the error not fixed? if not then what errors tell me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
The potential division by zero bug in the ETA calculation has been successfully fixed. The change modifies the calculateBusStatistics function to use currentSpeed if it's greater than 0, otherwise fall back to averageSpeed if available, preventing division by zero when the bus is temporarily stopped but has historical speed data.
Fixes: #275
🔧 Type of Change
Please mark the relevant option(s):
🧪 How Has This Been Tested?
Describe the tests you ran to verify your changes.
✅ Checklist
Please confirm the following: