Electron

[colincarter]

Note

Introduce Electron runtime (main/preload/renderer/uploader) and add iOS RNFS project with integration test harness, plus podspec and tooling/config setup.

• Electron:
  • Add app scaffolding and runtime code in src/electron/{main,preload,renderer,uploader}.ts with typings (window.d.ts, types.ts) and utilities (utf8.ts).
  • New entrypoints and wiring via src/index.ts.
• iOS:
  • Add ios/RNFS.xcodeproj and RNFS.podspec for CocoaPods integration.
  • Introduce full Integration Tests app (IntegrationTests/*), Xcode project/scheme, and test cases.
• Build/Tooling:
  • Add TypeScript configs (tsconfig*.json, tsconfig.build.json), Babel and ESLint configs, and project scripts via package.json.
  • Configure repo tooling (lefthook, Yarn v4, editor/formatter settings).

^{Written by Cursor Bugbot for commit c2e58a1. This will update automatically on new commits. Configure here.}

[cursor]

Bug: Type Definitions Path Mismatch

The "exports" field specifies "types" pointing to "./lib/typescript/src/index.d.ts", but the "types" field at the root level (line 6) points to "./lib/typescript/src/index.d.ts". However, the react-native-builder-bob configuration (lines 101-118) only generates TypeScript declarations without a nested "src" subdirectory in the output. The typescript target will output to "lib/typescript/" directly, not "lib/typescript/src/". This mismatch will cause TypeScript to fail to find type definitions.

 

[cursor]

Bug: Node.js Version Mismatch in .nvmrc

Invalid Node.js version specified. The version "v22.20.0" does not exist. Node.js v22.x latest stable version is v22.11.0 as of October 2025. This will cause errors when tools attempt to use this .nvmrc file to install or switch to the specified Node version. The version should be corrected to a valid Node.js release (e.g., v22.11.0 or the intended version).

 

[cursor]

Bug: Missing Package Metadata Causes Import Failures

The package.json is missing essential fields like main, version, description, dependencies, and peerDependencies. This prevents the package from being properly imported and used, as required dependencies (e.g., base-64, utf8) won't be installed, leading to runtime errors.

 

[cursor]

Bug: Inconsistent Timestamp Handling in touch Function

In the touch function, when calculating ctimeTime for iOS, the code uses (ctime && ctime.getTime()) || 0, but this will evaluate to 0 if ctime.getTime() returns 0 (which is a valid timestamp for January 1, 1970). The original code in FS.common.js had the same issue. However, comparing to line 743 which correctly handles mtime && mtime.getTime() without the || 0, the ctime handling is inconsistent and could pass undefined to the native module if ctime is provided but getTime() returns a falsy value. The pattern should be (ctime && ctime.getTime()) || 0 for both, or the function should validate that getTime() results are numbers.

 

[cursor]

Bug: TypeScript Type Mismatch in stat() Function

The stat() function returns a StatResult with ctime and mtime as number types (line 45-46 in type definition), but the implementation converts them to Date objects (lines 318-319). This type mismatch means the actual returned values don't match the declared TypeScript types, which will cause runtime type errors when consumers expect numbers but receive Date objects.

 

[cursor]

Bug: Error Handling Fails to Propagate; Subscriptions Leak

In the downloadFile error handler, the code catches an error and then returns Promise.reject(e), but this is inside a .catch() handler which means the rejection isn't actually doing anything useful - it should either re-throw or just let the error propagate. Additionally, subscriptions are not removed when an error occurs, potentially causing memory leaks.

 

[cursor]

Bug: JSX Runtime Mismatch Causes React Errors

The tsconfig.json sets "jsx": "react-jsx" which uses the automatic JSX runtime (React 17+), but this appears to be for a React Native project that may be using an older version of React. The PR title "Electron" and the deleted files suggest this might be a migration or cleanup, but the JSX transform setting could cause runtime errors if the project doesn't support the automatic JSX runtime. This would require importing React explicitly in files with JSX, otherwise components will fail at runtime with "React is not defined" errors.

 

[cursor]

Bug: Stat Function Missing 'name' Property

The stat function returns an object missing the 'name' property that is defined in the StatResult type (line 41). The returned object should include 'name: result.name' to match the type definition.

 

[cursor]

Bug: Null Handling Error in File Upload

The uploadFiles promise handler casts 'res' to UploadResult using 'as UploadResult', but the actual type is 'UploadResult | null'. If res is null, this will incorrectly return null as an UploadResult, potentially causing runtime errors when the caller tries to access properties on the result.

 

[cursor]

Bug: Missing Build Output Causes Package Breakage

The package.json changes the main entry point from "FS.common.js" to "./lib/module/index.js" and types from "index.d.ts" to "./lib/typescript/src/index.d.ts". However, the diff shows that FS.common.js is being deleted (lines 1-612 in FS.common.js are removed). This means the new entry points must exist for the package to work, but there's no evidence in the diff that "./lib/module/index.js" or the corresponding TypeScript files are being created. The build script on line 41 mentions "bob build" which should generate the lib folder, but this creates a broken state where the package cannot be used until the build runs successfully. This is particularly problematic because the "files" array (lines 15-33) includes "lib" but this directory won't exist in the repository.

 

[cursor]

Bug: Bug

The tvOS target's PBXSourcesBuildPhase (6456441B1EB8DA9100672408) has an empty files array. Its source files were removed during the project file update, but new references were not added, which will cause compilation failures for the tvOS target.

 

[cursor]

Bug: Duplicate Yarn ignore patterns with inconsistent negations

The .yarn/* pattern with its negations appears twice in the file. The first occurrence (lines 65-70) doesn't include !.yarn/cache, while the second (lines 88-94) does. This duplication creates conflicting rules where .yarn/cache handling is ambiguous, potentially causing unintended files to be tracked or ignored.

Additional Locations (1)

• .gitignore#L64-L70

 

[cursor]

Bug: Incorrect backslash escape in buckd ignore pattern

The pattern \.buckd/ uses a backslash to escape the dot, but dots aren't special characters in gitignore syntax. This causes Git to match a directory literally named \.buckd/ (including the backslash character) rather than the intended .buckd/ directory, preventing the Buck daemon directory from being properly ignored.

 

[cursor]

Bug: Flow parser configured but Flow removed

Prettier is configured to use the Flow parser for *.js files, but .flowconfig was removed in this commit. This creates an inconsistency where Prettier expects Flow type annotations in JavaScript files but Flow is no longer configured or available in the project, potentially causing formatting errors or unexpected behavior.