Skip to content

Conversation

@OverOrion
Copy link

No description provided.

@OverOrion OverOrion force-pushed the feat/multiple-cas branch 3 times, most recently from a6f2e62 to 89773a8 Compare December 18, 2025 09:08
Copy link

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to contribute this back to upstream.

There are 2 questions I would be interested in, but those are not blockers in any way:

  • I have memories that it is possible to create a cert trust chain, and the Windows clients sent the entire chain except for the root CA. In that case, thumbprint check may have to be done on the last cert's issuer, not on the first.

  • Listing multiple thumbprints in the enumerate response worked as far as I remember. We discussed that it is no longer the case (or I remember incorrectly), so you populated a hashtable instead. Using the issuer field as key should be good enough?!
    Maybe we could check the exact generated SOUP payload to verify if this list idea works or not.

@MrAnno
Copy link

MrAnno commented Jan 14, 2026

I'd suggest opening an upstream PR, allowing the maintainers/authors to comment on it.
If we don't receive any response within a week, I'd happily merge this in our fork (there won't be compat issues even if we have to change the implementation based on their review).

@MrAnno MrAnno force-pushed the main branch 2 times, most recently from cb89e9b to 3ba0587 Compare January 19, 2026 09:35
This is done in preparation for supporting multiple CAs

Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
This is done in preparation for supporting multiple CAs

Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
… subject

Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion OverOrion marked this pull request as ready for review January 19, 2026 09:56
@OverOrion OverOrion requested a review from MrAnno January 19, 2026 10:04
@MrAnno MrAnno merged commit 22999e4 into main Jan 19, 2026
1 check passed
@MrAnno MrAnno deleted the feat/multiple-cas branch January 19, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants