Update get_customer_verify_beneficial_ownership_from_body/1 to match resp#5
Open
jmillxyz wants to merge 1 commit intoaxlepayments:mainfrom
Conversation
axelclark
approved these changes
Aug 2, 2024
axelclark
reviewed
Aug 2, 2024
axelclark
left a comment
There was a problem hiding this comment.
Apologies for the approval, I got confused and thought this PR was in our repo...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dwolla endpoint at
/customers/{id}returns a few_links; one of those is used to populate theDwolla.Customerstruct fieldverify_beneficial_ownership.The response I see when hitting this endpoint is (irrelevant portions omitted):
I updated the first
get_customer_verify_beneficial_ownership_from_body/1function clause to account for this.Please let me know if I can help with tests, or whether you can update the test factory to properly account for this scenario -- it looks like it uses real data from a sandbox account?
Thanks!