feat!: Do not parse response data as utf-8#51
Open
dany-fedorov wants to merge 1 commit intoaxiomzen:masterfrom
Open
feat!: Do not parse response data as utf-8#51dany-fedorov wants to merge 1 commit intoaxiomzen:masterfrom
dany-fedorov wants to merge 1 commit intoaxiomzen:masterfrom
Conversation
Parsing binary data as utf-8 can cause problems, e.g. pdf file. Parsing as utf-8 replaces bytes that cannot be parsed with replacement character - https://en.wikipedia.org/wiki/Specials_(Unicode_block)#:~:text=The%20replacement%20character%20%EF%BF%BD%20(often,data%20to%20a%20correct%20symbol For example bytes FB, FC, FD will each be replaced with replacement character which is 3 bytes long and the result will look like this - EF BF BD, EF BF BD, EF BF BD BREAKING CHANGE: Changes the type of oldBody argument from string to Buffer
Author
|
Hey, this is going to need a major version bump if you're ok with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing binary data as utf-8 can cause problems, e.g. pdf file. Parsing as utf-8 replaces bytes that cannot be parsed with replacement character - https://en.wikipedia.org/wiki/Specials_(Unicode_block)#:~:text=The%20replacement%20character%20%EF%BF%BD%20(often,data%20to%20a%20correct%20symbol
For example bytes FB, FC, FD will each be replaced with replacement character which is 3 bytes long and the result will look like this - EF BF BD, EF BF BD, EF BF BD
BREAKING CHANGE: Changes the type of oldBody argument from string to Buffer